[libvirt] [PATCH v7 00/20] Refactor virQEMUCapsInitQMPCommand (for BaselineHypervisorCPU using QEMU QMP exchanges)

Jiri Denemark jdenemar at redhat.com
Tue Feb 19 09:04:43 UTC 2019


This series is a replacement for the refactoring part (the first 22
patches) of the "BaselineHypervisorCPU using QEMU QMP exchanges" series
[1] from Chris.

In a nutshell this series moves virQEMUCapsInitQMPCommand related code
to qemu_process.c and refactors it so that it can be used by both the
QEMU capabilities probing code and the upcoming code for calling QMP
commands internally for some CPU related APIs on s390.

I'm sending this refactoring part separated because it's mostly ready
for being pushed. I ACKed most of the patches in v6, but some patches
needed to be modified a bit or replaced by a bit different code. Thus
I'm sending them for review rather than pushing this part right away.

See individual patches for changes since v6.

[1] https://www.redhat.com/archives/libvir-list/2019-January/msg00310.html

Chris Venteicher (15):
  qemu_process: Move process code from qemu_capabilities
  qemu_process: Rename identifiers moved from qemu_capabilities
  qemu_process: Limit qemuProcessQMPNew to const input strings
  qemu_process: Refer to proc not cmd in process code
  qemu_process: Use consistent name for stop process function
  qemu_capabilities: Stop QEMU process before freeing
  qemu_process: Use qemuProcessQMP struct for a single process
  qemu_process: Introduce qemuProcessQMPStart
  qemu_process: Move monitor code to qemuProcessQMPConnectMonitor
  qemu_process: Store libDir in qemuProcessQMP struct
  qemu_process: Setup paths within qemuProcessQMPInit
  qemu_process: Stop retaining monitor config in qemuProcessQMP
  qemu_process: Document and cleanup qemuProcessQMPNew
  qemu_process: Use unique directories for QMP processes
  qemu_process: Enter QMP command mode when starting QEMU Process

Jiri Denemark (5):
  qemu_capabilities: Refactor virQEMUCapsInitQMP
  qemu_process: Don't ignore errors in virQEMUCapsInit
  qemu_capabilities: Log probe failure in virQEMUCapsInitQMPSingle
  qemu_process: Hide qmperr inside qemuProcessQMP
  qemu_process: Hide qemuProcessQMPStop

 src/qemu/qemu_capabilities.c | 356 ++++++-----------------------------
 src/qemu/qemu_process.c      | 324 +++++++++++++++++++++++++++++++
 src/qemu/qemu_process.h      |  29 +++
 src/qemu/qemu_processpriv.h  |   2 +
 tests/qemucapabilitiestest.c |   9 +
 5 files changed, 419 insertions(+), 301 deletions(-)

-- 
2.20.1




More information about the libvir-list mailing list