[libvirt] [PATCH v2 1/3] vircommand: Ensure buffers are NULL-terminated

Daniel P. Berrangé berrange at redhat.com
Tue Feb 19 13:52:18 UTC 2019


On Wed, Feb 13, 2019 at 01:04:06PM +0100, Andrea Bolognani wrote:
> The memory allocated by VIR_REALLOC_N() is uninitialized,
> which means it's not possible to figure out whether any
> output was produced at all after the fact.
> 
> Since we don't care about the previous contents of buffers,
> if any, use VIR_FREE() followed by VIR_ALLOC_N() instead.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  src/util/vircommand.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)


Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list