[libvirt] [PATCH 07/20] qemu_process: Use qemuProcessQMP struct for a single process

Ján Tomko jtomko at redhat.com
Tue Feb 19 15:03:08 UTC 2019


On Tue, Feb 19, 2019 at 10:04:50AM +0100, Jiri Denemark wrote:
>From: Chris Venteicher <cventeic at redhat.com>
>
>In new process code, move from model where qemuProcessQMP struct can be
>used to activate a series of Qemu processes to model where one
>qemuProcessQMP struct is used for one and only one Qemu process.
>
>By allowing only one process activation per qemuProcessQMP struct, the
>struct can safely store process outputs like status and stderr, without
>being overwritten, until qemuProcessQMPFree is called.
>
>By doing this, process outputs like status and stderr can remain stored
>in the qemuProcessQMP struct without being overwritten by subsequent
>process activations.
>
>The forceTCG parameter (use / don't use KVM) will be passed when the
>qemuProcessQMP struct is initialized since the qemuProcessQMP struct
>won't be reused.
>
>Signed-off-by: Chris Venteicher <cventeic at redhat.com>
>Reviewed-by: Jiri Denemark <jdenemar at redhat.com>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
>
>Notes:
>    Version 7:
>    - no change
>
> src/qemu/qemu_capabilities.c | 19 +++++++++++++++----
> src/qemu/qemu_process.c      |  9 +++++----
> src/qemu/qemu_process.h      |  7 ++++---
> 3 files changed, 24 insertions(+), 11 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190219/9fa46b09/attachment-0001.sig>


More information about the libvir-list mailing list