[libvirt] [PATCH 09/20] qemu_process: Don't ignore errors in virQEMUCapsInit

[Ján Tomko]

On Tue, Feb 19, 2019 at 10:04:52AM +0100, Jiri Denemark wrote:
>While qemuProcessQMPRun and virQEMUCapsInitQMPMonitor* functions called
>from virQEMUCapsInit ignore some errors, the caller of virQEMUCapsInit
>would report an error unless usedQMP is true anyway. And since usedQMP
>can only be true if the probing code really succeeded (i.e., no errors
>were ignored), we can just simplify the logic by not ignoring the errors
>in the first place.
>

Thank you.

>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
>
>Notes:
>    Version 7:
>    - this is a rewritten version of
>          [PATCH 08/33] qemu_process: All ProcessQMP errors are fatal
>      from version 6
>
> src/qemu/qemu_capabilities.c | 17 +----------------
> src/qemu/qemu_process.c      | 27 +++++++++++----------------
> 2 files changed, 12 insertions(+), 32 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190219/f88f03f4/attachment-0001.sig>