[libvirt] [PATCH 19/20] qemu_process: Use unique directories for QMP processes

[Ján Tomko]

On Tue, Feb 19, 2019 at 10:05:02AM +0100, Jiri Denemark wrote:
>From: Chris Venteicher <cventeic at redhat.com>
>
>Multiple QEMU processes for QMP commands can operate concurrently.
>
>Use a unique directory under libDir for each QEMU process to avoid
>pidfile and unix socket collision between processes.
>
>The pid file name is changed from "capabilities.pidfile" to "qmp.pid"
>because we no longer need to avoid a possible clash with a qemu domain
>called "capabilities" now that the processes artifacts are stored in
>their own unique temporary directories.
>
>"Capabilities" was changed to "qmp" in the pid file name because these
>processes are no longer specific to the capabilities usecase and are
>more generic in terms of being used for any general purpose QMP message
>exchanges with a QEMU process that is not associated with a domain.
>
>Signed-off-by: Chris Venteicher <cventeic at redhat.com>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
>
>Notes:
>    Version 7:
>    - report error if mkdtemp fails
>
> src/qemu/qemu_process.c | 30 ++++++++++++++++++++----------
> src/qemu/qemu_process.h |  1 +
> 2 files changed, 21 insertions(+), 10 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190219/599af712/attachment-0001.sig>