[libvirt] [PATCH] testutils: Explicitly name virTestCompare*() arguments

Michal Privoznik mprivozn at redhat.com
Wed Feb 20 07:37:27 UTC 2019


On 2/19/19 9:19 PM, John Ferlan wrote:
> Assuming extraction (sigh) of the VIR_AUTOFREE,
> 
> Reviewed-by: John Ferlan<jferlan at redhat.com>
> 

While I'd definitely want this to be split into two patches if it was 
fixing something under src/, but this is under tests/ and therefore I 
did not bother. The reason for splitting a patch into smaller 
semanticaly divided patches is to help distro maintainers to ease 
backports. I don't think they will need to backport this patch, nor will 
they want only a part of it.

But I can do the split if you still want me to.

I'm postponing the push for now.

Thanks,
Michal




More information about the libvir-list mailing list