[libvirt] [PATCH] testutils: Explicitly name virTestCompare*() arguments

[Michal Privoznik]

On 2/20/19 1:56 PM, Andrea Bolognani wrote:
> On Wed, 2019-02-20 at 07:33 -0500, John Ferlan wrote:
>> On 2/20/19 2:37 AM, Michal Privoznik wrote:
>>> On 2/19/19 9:19 PM, John Ferlan wrote:
>>>> Assuming extraction (sigh) of the VIR_AUTOFREE,
>>>
>>> While I'd definitely want this to be split into two patches if it was
>>> fixing something under src/, but this is under tests/ and therefore I
>>> did not bother. The reason for splitting a patch into smaller
>>> semanticaly divided patches is to help distro maintainers to ease
>>> backports.
> 
> And reviewers, and people digging through history possibly years
> down the line.
> 
> Whether the change is in src/, tests/ or whatever else shouldn't
> make a difference, it's all code and we routinely have to fix bugs
> both in the library and in the corresponding test suite.
> 
> There is barely ever a reason *not* to split changes into smaller,
> independent units; having to write "at the same time" in the commit
> message should be your hint that you're doing it wrong ;)


Let me see, the whole sentence reads as follows:

     At the same time, rework virTestCompareToULL a bit so that local
     variables are named in the same fashion.

I don't see any problem with that. But okay, I'll send v2 splitting this 
tiny patch into even smaller ones :-P

Michal