[libvirt] [PATCH v2 3/3] testutils: Explicitly name virTestCompare*() arguments

Ján Tomko jtomko at redhat.com
Wed Feb 20 14:24:26 UTC 2019


On Wed, Feb 20, 2019 at 02:20:10PM +0100, Michal Privoznik wrote:
>Currently, some arguments are called strcontent and strsrc, or
>content and src or some other combination. This makes it
>impossible to see at the first glance what argument is supposed
>to represent 'expected' value and which one represents 'actual'
>value. Rename the arguments to make it obvious.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>Reviewed-by: John Ferlan <jferlan at redhat.com>
>---
> tests/testutils.c | 34 +++++++++++++---------------------
> tests/testutils.h | 10 +++++-----
> 2 files changed, 18 insertions(+), 26 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190220/40e7f0a0/attachment-0001.sig>


More information about the libvir-list mailing list