[libvirt] [PATCH 0/1] update copyright notice

[Peter Krempa]

On Fri, Feb 22, 2019 at 11:42:04 +0300, David Kiarie wrote:
> On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar at redhat.com> wrote:
> 
> > On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote:
> > > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote:
> > > > it looks sensible that the copyright notice on the affected files in
> > > > updated as in this patch so as to also cover another party who hugely
> > > > participated in writing the code.
> > >
> > > I must point out that you specifically asked us to remove your name
> > > from the files:
> > >
> > > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html
> > >
> > > Which was fulfilled after the discussion in the thread above by:
> > >
> > > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html
> > >
> > > And now lives in the repo as:
> > >
> > > commit d894e49292ae5135b6a9f44a634b5cfca4376f19
> > > Author: David Kiarie <davidkiarie4 at gmail.com>
> > > Date:   Tue May 8 15:40:00 2018 +0300
> > >
> > >     xenconfig: remove my name and email from files
> > >
> > >
> > > Did you change your mind?
> >
> 
> yes, i will actually share the copyright, if possible.

Given our previous experience I'm worried that you might change your
mind again.

I'd like you to pledge that it's your final decision and you will
not attempt to delete it again after some time.

> > Moreover, you removed 'Author: Kiarie Kahurani' lines while you want to
> > add your name into a Copyright line now. Only SUSE was mentioned as the
> > copyright holder when you created the files. This makes me think you
> > might have contributed this as part of your contract with SUSE in which
> > case you are most likely not the copyright holder (even though you
> > didn't use a @suse.com email, but that's not rare some people just keep
> > using their personal email).
> >
> 
> i did this as part of GSoC. there was no contract.

I'm not entirely sure, but we might want to ask the SuSE folks whether
they agree.

> i think an email is personal enough that it shouldn't appear on copyright
> notice just like i can't have my phone number on the copyright declaration.

As we've pointed out when you wanted to delete your name in the first
place, most of the people looking at the code will be able to figure out
the commit that added your name here and that commit does show your
e-mail address.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190222/6cf1d6e4/attachment-0001.sig>