[libvirt] [PATCH 1/1] virfile: added GPFS as shared fs

[Peter Krempa]

On Mon, Feb 25, 2019 at 09:39:39 +0100, dmichelotto wrote:
> Added GPFS as shared file system recognized during live migration
> security checks.

You could mention that GPFS stands for 'IBM General Parallel File System (GPFS)'.

> 
> This becomes from upstream code on https://libvirt.org/git from master branch

This should not be part of the commit message.

> 
> BUG: https://bugzilla.redhat.com/show_bug.cgi?id=1679528
> ---

Please note that the libvirt project requires that you comply with the
developer certificate of origin. See https://libvirt.org/hacking.html#patches
part 6 and https://developercertificate.org/.

Also we prefer if you use full name as the author when sending the
patch.


>  src/util/virfile.c            | 9 ++++++++-
>  src/util/virfile.h            | 1 +
>  tests/virfiledata/mounts3.txt | 1 +
>  tests/virfilemock.c           | 5 +++++
>  tests/virfiletest.c           | 1 +
>  5 files changed, 16 insertions(+), 1 deletion(-)

The changes look good to me but I'd prefer if you send the patch again
including the sign-off and proper name.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190225/c5779c80/attachment-0001.sig>