[libvirt] [PATCH] virfile: added GPFS as shared fs

[Diego Michelotto]

HI Peter

> Il giorno 26 feb 2019, alle ore 09:08, Peter Krempa <pkrempa at redhat.com> ha scritto:
> 
> On Mon, Feb 25, 2019 at 19:19:03 +0100, Diego Michelotto wrote:
>> From: dmichelotto <diego.michelotto at cnaf.infn.it <mailto:diego.michelotto at cnaf.infn.it>>
> 
> With your permission I'll remove the above line when applying the patch
> so that your authorship of the patch shows up as:
> 
> Author: Diego Michelotto <diego.michelotto at cnaf.infn.it <mailto:diego.michelotto at cnaf.infn.it>>
> 
> instead of
> 
> Author: dmichelotto <diego.michelotto at cnaf.infn.it <mailto:diego.michelotto at cnaf.infn.it>>

Sure, you can change it.

> 
>> 
>> Added GPFS as shared file system recognized during live migration
>> security checks.
>> 
>> GPFS is 'IBM General Parallel File System' also called
>> 'IBM Spectrum Scale'
>> 
>> BUG: https://bugzilla.redhat.com/show_bug.cgi?id=1679528
>> 
>> Signed-off-by: Diego Michelotto <diego.michelotto at cnaf.infn.it>
>> ---
>> src/util/virfile.c            | 9 ++++++++-
>> src/util/virfile.h            | 1 +
>> tests/virfiledata/mounts3.txt | 1 +
>> tests/virfilemock.c           | 5 +++++
>> tests/virfiletest.c           | 1 +
>> 5 files changed, 16 insertions(+), 1 deletion(-)
> 
> One thing which might be worth exploring is whether GPFS is also
> migratable with cache != none and thus should be also added to
> virStorageFileIsClusterFS.

GPFS stalls badly when a process issues a lot of fsyncs in a short timeframe.
It is better if the VM I/O is not synchronous, with previous version of libvirt
we are using writeback caching.

If you prefer I’ll try to make a new patch, but let me know if it’s easier for you to add yourself GPFS to 
the virStorageFileIsClusterFS function.

> 
> ACK.
> 
> Depending on the angle of view this can be viewed both as a bug and as a
> feature. Since we are feature freeze, is anybody objecting in pushing
> this right away? (obviously I'm not going to push it right now)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190226/a40cb31a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2158 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190226/a40cb31a/attachment-0001.p7s>