[libvirt] [PATCH v2 2/4] util: string: Use VIR_AUTOSTRINGLIST instead of VIR_AUTOPTR(virString)

[Erik Skultety]

On Tue, Feb 26, 2019 at 04:48:24PM +0100, Peter Krempa wrote:
> Use of VIR_AUTOPTR and virString is confusing as it's a list and not a
> single pointer. Replace it by VIR_AUTOSTRINGLIST as string lists are
> basically the only sane NULL-terminated list we can have.
>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/lxc/lxc_process.c                  |  2 +-
>  src/qemu/qemu_conf.c                   |  8 ++++----
>  src/storage/storage_backend_sheepdog.c |  4 ++--
>  src/storage/storage_backend_zfs.c      | 10 +++++-----
>  src/util/vircommand.c                  |  2 +-
>  src/util/virfirewall.c                 |  2 +-
>  src/util/virprocess.c                  |  2 +-
>  src/util/virstoragefile.c              | 10 +++++-----
>  src/xenconfig/xen_common.c             |  6 +++---
>  9 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
> index a3481bfa08..e0729a24bf 100644
> --- a/src/lxc/lxc_process.c
> +++ b/src/lxc/lxc_process.c
> @@ -1181,7 +1181,7 @@ int virLXCProcessStart(virConnectPtr conn,
>      size_t i;
>      char *logfile = NULL;
>      int logfd = -1;
> -    VIR_AUTOPTR(virString) veths = NULL;
> +    VIR_AUTOSTRINGLIST veths = NULL;

Since I'm responsible (as a reviewer) for breaking the VIR_AUTO consistency in
terms of where to declare the variables (not that it would matter in any way),
I'm not going to argue about that anymore.

With the adjustments coming from the previous patch:
Reviewed-by: Erik Skultety <eskultet at redhat.com>