[libvirt] [PATCH v2 09/11] virsh: Expose bulk snapshot dumpxml/redefine

John Ferlan jferlan at redhat.com
Wed Feb 27 16:54:21 UTC 2019



On 2/23/19 4:24 PM, Eric Blake wrote:
> Add flags to the 'dumpxml' and 'snapshot-create' commands to pass
> the newly-added bulk snapshot flags through.
> 
> For command-line convenience, I intentionally made --redefine-list
> imply --redefine, even though the counterpart C flags are distinct
> (and you get an error if you pass _REDEFINE_LIST without _REDEFINE).
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  tools/virsh-domain.c   |  7 +++++++
>  tools/virsh-snapshot.c | 14 ++++++++++++++
>  2 files changed, 21 insertions(+)
> 

Need to update virsh.pod as well to describe new arguments. Do you think
that a separation of the dumpxml and the parse/create into order
pertinent patches would be better? That is the --snapshots for dumpxml
after patch7 (which probably could swap places w/ patch6) so that the
dumpxml and parse/create functionality is all in logical order. It's not
that important.

John

[...]




More information about the libvir-list mailing list