[libvirt] [PATCH v1 10/15] qemufirmwaretest: Test qemuFirmwareFetchConfigs()

Laszlo Ersek lersek at redhat.com
Thu Feb 28 10:23:05 UTC 2019


On 02/27/19 11:04, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/Makefile.am                             |  1 +
>  .../etc/qemu/firmware/40-ovmf-sb.json         |  1 +
>  .../etc/qemu/firmware/60-ovmf.json            |  0
>  .../user/.config/qemu/firmware/10-bios.json   |  0
>  .../share/qemu/firmware}/40-bios.json         |  0
>  .../share/qemu/firmware}/50-ovmf-sb.json      |  0
>  .../share/qemu/firmware}/60-ovmf.json         |  0
>  .../share/qemu/firmware}/70-aavmf.json        |  0
>  tests/qemufirmwaretest.c                      | 69 +++++++++++++++++--
>  9 files changed, 66 insertions(+), 5 deletions(-)
>  create mode 120000 tests/qemufirmwaredata/etc/qemu/firmware/40-ovmf-sb.json
>  create mode 100644 tests/qemufirmwaredata/etc/qemu/firmware/60-ovmf.json
>  create mode 100644 tests/qemufirmwaredata/home/user/.config/qemu/firmware/10-bios.json
>  rename tests/qemufirmwaredata/{ => usr/share/qemu/firmware}/40-bios.json (100%)
>  rename tests/qemufirmwaredata/{ => usr/share/qemu/firmware}/50-ovmf-sb.json (100%)
>  rename tests/qemufirmwaredata/{ => usr/share/qemu/firmware}/60-ovmf.json (100%)
>  rename tests/qemufirmwaredata/{ => usr/share/qemu/firmware}/70-aavmf.json (100%)

Right, so I think it makes sense to introduce the double-digit priority
prefixes first in this patch, as part of the rename. They matter here,
but they don't matter in the previous test case.

No other comments for now regarding this patch; I hope that's not a problem.

Thanks
Laszlo




More information about the libvir-list mailing list