[libvirt] [PATCH RFC 29/51] qemu: Allocate diskPriv->blockjob only when there's a blockjob

Ján Tomko jtomko at redhat.com
Mon Jan 7 15:24:57 UTC 2019


On Wed, Dec 12, 2018 at 06:08:45PM +0100, Peter Krempa wrote:
>Rather than storing the presence of the blockjob in a flag we can bind
>together the lifecycle of the job with the lifecycle of the object which
>is tracking the data for it.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_blockjob.c | 76 +++++++++++++++++++++++++++++-----------
> src/qemu/qemu_blockjob.h |  1 -
> src/qemu/qemu_domain.c   |  5 ---
> 3 files changed, 55 insertions(+), 27 deletions(-)
>
>@@ -333,7 +355,7 @@ qemuBlockJobEventProcessLegacy(virQEMUDriverPtr driver,
>
>
> /**
>- * qemuBlockJobUpdate:
>+ * qemuBlockJobUpdateDisk:

Unrelated change.

>  * @vm: domain
>  * @disk: domain disk
>  * @error: error (output parameter)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190107/9d2a7550/attachment-0001.sig>


More information about the libvir-list mailing list