[libvirt] [PATCH v2 3/3] maint: split long lines for BSD syntax-check

[Ján Tomko]

On Mon, Jan 07, 2019 at 09:11:03AM -0600, Eric Blake wrote:

[...]

>>>        | $(SED) 's/_("\([^\"]\|\\.\)\+"//;s/[     ]"%s"//' \
>>>        | $(GREP) '[     ]"' && \
>>>       { echo '$(ME): found unmarked diagnostic(s)' 1>&2; \
>>
>> With the /dev/null changes removed or justified:
>
>I hope that was the justification you were looking for (and it matches

Yes.

Jano

>the gnulib rewrite that uses /dev/null in every conversion to xargs grep
>where grep's output differs based on number of file names present - note
>that 'grep -L' does not have different output, so it doesn't need the
>/dev/null trick, but we didn't have uses of grep -L in cfg.mk).
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190107/50d7106b/attachment-0001.sig>