[libvirt] [PATCH] util: make forgotten changes suggested during review of commit d40b820c

Ján Tomko jtomko at redhat.com
Mon Jan 14 11:09:15 UTC 2019


On Sun, Jan 13, 2019 at 12:42:20AM -0500, Laine Stump wrote:
>I had intended to make these changes to commit d40b820c before
>pushing, but forgot about it during the day between the initial review
>and ACK.
>
>Neither change is significant - just returning immediately when
>virNetDevGetName() faills (instead of logging a debug message first)

*fails

>and eliminating a comment that adds to confusion rather than
>eliminating it. Still, the changes should be made to be more consistent with nearly identical code just a few lines up (added in commit 7282f455)

Please wrap this long line.

>
>Signed-off-by: Laine Stump <laine at laine.org>
>---
> src/util/virnetdevip.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190114/5d81aa8a/attachment-0001.sig>


More information about the libvir-list mailing list