[libvirt] [PATCH 3/5] util: new function virFirewallDInterfaceSetZone()
Daniel P. Berrangé
berrange at redhat.com
Tue Jan 15 16:44:44 UTC 2019
On Wed, Jan 09, 2019 at 09:57:35PM -0500, Laine Stump wrote:
> Sets the firewalld zone of the given interface. This function assumes
> that you've already called virFirewallDIsActive(), and relies on
> virDBusCallMethod's standard error reporting to log any errors.
virFirewallDIsActive method doesn't exist. Presumably you
mean virFirewallDStatus though i suggested a rename for
that too :-)
>
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
> src/libvirt_private.syms | 1 +
> src/util/virfirewalld.c | 23 +++++++++++++++++++++++
> src/util/virfirewalld.h | 3 +++
> 3 files changed, 27 insertions(+)
Assuming commit message typo is fixed
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list