[libvirt] [PATCH RFC 18/51] qemu: blockjob: Add functions for block job state control
Peter Krempa
pkrempa at redhat.com
Thu Jan 17 14:08:30 UTC 2019
On Mon, Jan 07, 2019 at 14:35:08 +0100, Ján Tomko wrote:
> On Wed, Dec 12, 2018 at 06:08:34PM +0100, Peter Krempa wrote:
> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
[...]
> > index 637307806b..9e5171744e 100644
> > --- a/src/qemu/qemu_driver.c
> > +++ b/src/qemu/qemu_driver.c
> > @@ -4716,7 +4716,7 @@ processBlockJobEvent(virQEMUDriverPtr driver,
> > int status)
> > {
> > virDomainDiskDefPtr disk;
> > - qemuBlockJobDataPtr job;
> > + qemuBlockJobDataPtr job = NULL;
> >
> > if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0)
> > return;
> > @@ -4731,7 +4731,11 @@ processBlockJobEvent(virQEMUDriverPtr driver,
> > goto endjob;
> > }
> >
> > - job = QEMU_DOMAIN_DISK_PRIVATE(disk)->blockjob;
> > + if (!(job = qemuBlockJobDiskGetJob(disk))) {
>
> Can qemuBlockJobDiskGetJob really return NULL here?
Not at this point in the series but it will become the case later.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190117/94552ee5/attachment-0001.sig>
More information about the libvir-list
mailing list