[libvirt] [PATCH 18/18] qemu: domcaps: Report disk <enum name="model">
Cole Robinson
crobinso at redhat.com
Tue Jan 22 17:48:38 UTC 2019
On 01/21/2019 12:04 PM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
>> This generates new XML like:
>>
>> <disk>
>> <enum name='model'>
>> <value>virtio-transitional</value>
>> <value>virtio-non-transitional</value>
>> </enum>
>> </disk>
>
> <value>virtio</value> should appear in the output as well...
>
> [...]
>> @@ -5286,6 +5286,13 @@ virQEMUCapsFillDomainDeviceDiskCaps(virQEMUCapsPtr qemuCaps,
>> if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_ICH9_AHCI))
>> VIR_DOMAIN_CAPS_ENUM_SET(disk->bus, VIR_DOMAIN_DISK_BUS_SATA);
>>
>> + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_BLK_TRANSITIONAL))
>> + VIR_DOMAIN_CAPS_ENUM_SET(disk->model,
>> + VIR_DOMAIN_DISK_MODEL_VIRTIO_TRANSITIONAL);
>> + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_BLK_NON_TRANSITIONAL))
>> + VIR_DOMAIN_CAPS_ENUM_SET(disk->model,
>> + VIR_DOMAIN_DISK_MODEL_VIRTIO_NON_TRANSITIONAL);
>
> ... but it seems we don't have a capability for that? Weird.
>
Okay I'll fix.
Thank you very much for the timely and thorough reviews Andrea!
Thanks,
Cole
More information about the libvir-list
mailing list