[libvirt] [PATCH 2/5] vircgroup: Try harder to kill cgroup

Daniel P. Berrangé berrange at redhat.com
Fri Jan 25 14:00:50 UTC 2019


On Fri, Jan 25, 2019 at 02:31:46PM +0100, Michal Privoznik wrote:
> Prior to rewrite of cgroup code we only had one backend to try.
> After the rewrite the virCgroupBackendGetAll() returns both
> backends (for v1 and v2). However, not both have to really be
> present on the system which results in killRecursive callback
> failing which in turn might mean we won't try the other backend.
> 
> At the same time, this function reports no error as it should.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Ahhh, this explains the bizarre unidentified error I was getting
from Destroy() when testing the Go bindings in 5.0.0 libvirt on
a host that only supports v1


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list