[libvirt] [PATCH] lib: Use more of VIR_STEAL_PTR()

Michal Privoznik mprivozn at redhat.com
Mon Jan 28 14:09:08 UTC 2019


On 1/28/19 2:37 PM, Ján Tomko wrote:
> On Mon, Jan 28, 2019 at 02:03:07PM +0100, Michal Privoznik wrote:
>> From: Your Name <you at example.com>
>>
> 
> The patch was authored by 'Your Name'... [0]
> 
>> We have this very handy macro called VIR_STEAL_PTR() which steals
>> one pointer into the other and sets the other to NULL. The
>> following coccinelle patch was used to create this commit:
>>
>>  @ rule1 @
>>  identifier a, b;
>>  @@
>>
>>  - b = a;
>>    ...
>>  - a = NULL;
>>  + VIR_STEAL_PTR(b, a);
>>
>> Some places were clean up afterwards to make syntax-check happy
> 
> *cleaned
> 
>> (e.g. some curly braces were removed where the body become a one
>> liner).
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> 
> [0] ...but it's missing their sign-off.

Ah, this is because actually I have coccinelle installed in a virtual 
machine of mine and I don't have git properly configured there O:-)

Anyway, fixed before pushing. Thanks.

Michal




More information about the libvir-list mailing list