[libvirt] [PATCH 28/32] tests: qemuxml2argv: Add a 'serial' value for a SCSI disk

Peter Krempa pkrempa at redhat.com
Mon Jan 28 16:18:57 UTC 2019


Upcoming addition of a new field will need to make sure that SCSI disk
serial is tested as well. Add a case to one of the existing tests.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args | 2 +-
 tests/qemuxml2argvdata/disk-scsi.xml                | 1 +
 tests/qemuxml2xmloutdata/disk-scsi.xml              | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args b/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args
index ac9f3ff02e..68a8b2921d 100644
--- a/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args
+++ b/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args
@@ -34,7 +34,7 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
 -device scsi-hd,bus=scsi0.0,scsi-id=0,drive=drive-scsi0-0-0,id=scsi0-0-0 \
 -drive file=/tmp/scsidisk2.img,format=raw,if=none,id=drive-scsi1-0-0-0 \
 -device scsi-hd,bus=scsi1.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi1-0-0-0,\
-id=scsi1-0-0-0 \
+id=scsi1-0-0-0,serial=abcdefghijklmn \
 -drive file=/tmp/scsidisk3.img,format=raw,if=none,id=drive-scsi2-0-0-0 \
 -device scsi-hd,bus=scsi2.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi2-0-0-0,\
 id=scsi2-0-0-0,wwn=0x5000c50015ea71ac \
diff --git a/tests/qemuxml2argvdata/disk-scsi.xml b/tests/qemuxml2argvdata/disk-scsi.xml
index 496d8cab39..dda413eb0c 100644
--- a/tests/qemuxml2argvdata/disk-scsi.xml
+++ b/tests/qemuxml2argvdata/disk-scsi.xml
@@ -28,6 +28,7 @@
       <source file='/tmp/scsidisk2.img'/>
       <target dev='sdb' bus='scsi'/>
       <address type='drive' controller='1' bus='0' target='0' unit='0'/>
+      <serial>abcdefghijklmn</serial>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/scsidisk3.img'/>
diff --git a/tests/qemuxml2xmloutdata/disk-scsi.xml b/tests/qemuxml2xmloutdata/disk-scsi.xml
index 96c0cfec74..9cfff4b14e 100644
--- a/tests/qemuxml2xmloutdata/disk-scsi.xml
+++ b/tests/qemuxml2xmloutdata/disk-scsi.xml
@@ -30,6 +30,7 @@
       <driver name='qemu' type='raw'/>
       <source file='/tmp/scsidisk2.img'/>
       <target dev='sdb' bus='scsi'/>
+      <serial>abcdefghijklmn</serial>
       <address type='drive' controller='1' bus='0' target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
-- 
2.20.1




More information about the libvir-list mailing list