[libvirt] [Qemu-devel] [PATCH] qmp: Deprecate query-nodes option of query-blockstats

[Anton Kuchin]

On 28/01/2019 18:37, Kevin Wolf wrote:
> Am 28.01.2019 um 16:15 hat Anton Kuchin geschrieben:
>> This option is broken since a6baa60807 in v2.9 and returns mostly
>> zeroes instead of real stats because actual querring of BlockStats
>> that resides in blk is missing.
>>
>> And it makes no sense because with this option BlockDriverState-s
>> are iterated but BlockAcctStats belong to BlockBackend and not BDS
>> since 7f0e9da6f13 in v2.5
>>
>> Signed-off-by: Anton Kuchin <antonkuchin at yandex-team.ru>
> Isn't query-nodes the only way to get wr_highest_offset for the protocol
> layer? oVirt depends on this, as far as I know.

Isn't it reported without query-nodes parameter as "wr_highest_offset" 
of "parent" stats entry?

What we get with query-nodes is essentially the same output, but without 
correct data from backend and with one more copy of almost empty data 
from protocol layer.

I'll try to find usages of this option in oVirt code.

>
> Kevin
>