[libvirt] [PATCH 0/7] Add support to list Storage Driver backend capabilities

Michal Privoznik mprivozn at redhat.com
Tue Jan 29 10:18:07 UTC 2019


On 1/16/19 2:15 AM, John Ferlan wrote:
> Although I suppose this could have been an RFC - I just went with
> a v1.  I would think at least the first 4 patches are non controversial.
> Beyond that it depends on what is "expected" as output for the
> capabilities output for the storage driver.
> 
> John Ferlan (7):
>    conf: Extract host XML formatting from virCapabilitiesFormatXML
>    conf: Alter virCapabilitiesFormatHostXML to take virCapsHostPtr
>    conf: Extract guest XML formatting from virCapabilitiesFormatXML
>    conf: Alter virCapabilitiesFormatGuestXML to take virCapsGuestPtr

ACK to these four ^^

>    conf: Introduce storage pool functions into capabilities

This one is fine on its own, but will need a preceeding patch to 
abstract virCaps even more.

>    storage: Process storage pool capabilities

This one will be okay if you fix those small issues I've raised.

>    storage: Add storage backend pool/vol API's to capability output
> 
>   src/conf/capabilities.c       | 449 ++++++++++++++++++++++------------
>   src/conf/capabilities.h       |  19 ++
>   src/conf/virstorageobj.h      |   4 +
>   src/libvirt_private.syms      |   1 +
>   src/storage/storage_backend.c |  65 +++++
>   src/storage/storage_backend.h |   3 +
>   src/storage/storage_driver.c  |  17 ++
>   7 files changed, 400 insertions(+), 158 deletions(-)
> 

Micha




More information about the libvir-list mailing list