[libvirt] [PATCH 05/11] qemu: security: Add 'backingChain' flag to qemuSecurity[Set|Restore]ImageLabel

Peter Krempa pkrempa at redhat.com
Wed Jan 30 15:10:13 UTC 2019


On Mon, Jan 28, 2019 at 09:27:51 -0500, John Ferlan wrote:
> 
> 
> On 1/23/19 11:11 AM, Peter Krempa wrote:
> > Allow callers use the new flag.
> > 
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> >  src/qemu/qemu_domain.c   |  4 ++--
> >  src/qemu/qemu_security.c | 10 ++++++----
> >  src/qemu/qemu_security.h |  6 ++++--
> >  3 files changed, 12 insertions(+), 8 deletions(-)
> > 
> 
> Assuming previous comment/adjustment request to use int instead of
> flag.... The "false"'s change to 0 and 'bool backingChain' to unsigned
> int flags...

Passing in the flags of the security driver at this level would be weird.
At this point I'll keep the flag in the function header and convert it
to the appropriate flags.

I don't really see a point in adding yet another set of flags for the
qemu_security stuff.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190130/94014c20/attachment-0001.sig>


More information about the libvir-list mailing list