[libvirt] [PATCH 2/4] qemu: Add PCI support for RISC-V guests

Ján Tomko jtomko at redhat.com
Thu Jan 31 16:31:06 UTC 2019


On Thu, Jan 31, 2019 at 03:34:19PM +0100, Andrea Bolognani wrote:
>virtio-mmio is still used by default, so if PCI is desired
>it's necessary to explicitly opt-in by adding an appropriate
>
>  <address type='pci' domain='0x0000' ... />
>
>element to the corresponding device.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> src/qemu/qemu_capabilities.c   | 4 +++-
> src/qemu/qemu_domain.c         | 2 ++
> src/qemu/qemu_domain_address.c | 3 ++-
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>index f504db7d05..6fe8693170 100644
>--- a/src/qemu/qemu_capabilities.c
>+++ b/src/qemu/qemu_capabilities.c
>@@ -1741,8 +1741,10 @@ bool virQEMUCapsHasPCIMultiBus(virQEMUCapsPtr qemuCaps,
>     /* If ARM 'virt' supports PCI, it supports multibus.
>      * No extra conditions here for simplicity.
>      */
>-    if (qemuDomainIsARMVirt(def))
>+    if (qemuDomainIsARMVirt(def) ||
>+        qemuDomainIsRISCVVirt(def)) {
>         return true;
>+    }

The comment above only mentions arm. Either decouple the conditions or
remove the comment. For simplicity.

>
>     return false;
> }

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190131/4f668dfa/attachment-0001.sig>


More information about the libvir-list mailing list