[libvirt] [PATCH 1/2] test_driver: Don't access @vm after it was set to NULL

Andrea Bolognani abologna at redhat.com
Tue Jul 2 09:57:11 UTC 2019


On Tue, 2019-05-14 at 17:12 +0200, Michal Privoznik wrote:
> If something goes wrong in testDomainGetDiskErrors() then we try
> to free any strings that were previously allocated in return
> array. Problem is, in my review of original patch (89320788ac4)
> I've mistakenly did some changes which result in possible NULL
> dereference (@vm is set to NULL as the first thing under cleanup
> label).
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/test/test_driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list