[libvirt] [PATCH] Do not keep empty log files for deleted domains

[Jan Zerebecki]

On 03/07/2019 08.55, Peter Krempa wrote:
> On Wed, Jul 03, 2019 at 08:32:21 +0200, Jan Zerebecki wrote:
>> On 03/07/2019 08.03, Peter Krempa wrote:
>>> I'm not sure that this is the right thing to do. virtlogd has some
>>> internal log rotation mechanisms
>>
>> logrotate is already in use here and this patch doesn't change what is
>> rotated nor how often it is rotated.
>>
>>> and also the SIGUSR1 action is reserved
>>> for re-exec updates and not for dealing with modified files
>>
>> The mechanism (re-exec) and implementation details for both uses do not
>> conflict.
> 
> The problem is that the logrotate configs predate use of virtlogd and I
> don't think they were adapted to be used together. In fact if I remember
> correctly the idea of virtlogd was to avoid using logrotate altogether.

virtlogd rotates by size and logrotate in this config by time, so they
work fine together. Yes, you could implement rotating out logfiles from
deleted domains in virtlogd, but I don't see a reason to reimplement it.

> Additionally virtlogd is currently used only with the qemu VM log files.
> Everything else logs itself, so your changes to libvirtd/lxc and others
> seem to be unnecessary.

I don't have some of these handy to test, how do you get them to reopen
logs?

-- 
Best regards,
Jan Zerebecki