[libvirt] [PATCH] remote: remove obsolete rule for generating sysvinit script

Daniel P. Berrangé berrange at redhat.com
Wed Jul 3 15:22:24 UTC 2019


On Wed, Jul 03, 2019 at 05:14:10PM +0200, Andrea Bolognani wrote:
> On Wed, 2019-07-03 at 14:14 +0100, Daniel P. Berrangé wrote:
> > The sysvinit script was previously removed in
> > 
> >   commit 912fe2df9d8628b2f3d54485f1cb919cb124d07a
> >   Author: Andrea Bolognani <abologna at redhat.com>
> >   Date:   Fri Mar 15 16:47:27 2019 +0100
> > 
> >     Drop support for "Red Hat" init scripts
> > 
> > A make rule was accidentally left behind.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/remote/Makefile.inc.am | 9 ---------
> >  1 file changed, 9 deletions(-)
> 
> My bad O:-)
> 
> I think it's unnecessary to include that much information about
> the original commit, just the (shortened) hash would be enough.

I've seen plenty of times when people cut & paste the wrong
hash, so it is always worth including down to the summary line.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list