[libvirt] [PATCH 05/14] libxl: Drop support for parsing sxpr format in libxlConnectDomainXMLFromNative

[Ján Tomko]

On Wed, Jul 03, 2019 at 02:37:57PM +0200, Peter Krempa wrote:
>We've dropped old xend support over a year ago. At this point we can
>also drop support for parsing very old configs.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> docs/drvxen.html.in      |  3 +--
> src/libxl/libxl_driver.c | 14 +++-----------
> 2 files changed, 4 insertions(+), 13 deletions(-)
>
>@@ -2702,16 +2701,9 @@ libxlConnectDomainXMLFromNative(virConnectPtr conn,
>                                driver->xmlopt)))
>             goto cleanup;
>     } else if (STREQ(nativeFormat, XEN_CONFIG_FORMAT_SEXPR)) {
>-        /* only support latest xend config format */
>-        if (!(def = xenParseSxprString(nativeConfig,
>-                                       NULL,
>-                                       -1,
>-                                       cfg->caps,
>-                                       driver->xmlopt))) {
>-            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
>-                           _("parsing sxpr config failed"));
>-            goto cleanup;
>-        }
>+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
>+                       _("conversion from 'xen-sxpr' format is no longer supported"));

Maybe use XEN_CONFIG_FORMAT_SEXPR here too?

>+        goto cleanup;
>     } else {

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190704/468aeeff/attachment-0001.sig>