[libvirt] [PATCH 5/8] snapshot: Factor out redefine cycle validation

[Peter Krempa]

On Fri, Jul 05, 2019 at 23:37:32 -0500, Eric Blake wrote:
> The code to check whether a redefined snapshot/checkpoint XML is
> attempting to create a cycle in the list of moments is lengthy, and
> common between the two types of list. Therefore, it belongs in the
> shared base file.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/conf/virdomainmomentobjlist.h   |  3 +++
>  src/conf/virdomainsnapshotobjlist.h |  3 +++
>  src/conf/snapshot_conf.c            | 41 ++++-------------------------
>  src/conf/virdomainmomentobjlist.c   | 40 ++++++++++++++++++++++++++++
>  src/conf/virdomainsnapshotobjlist.c |  9 +++++++
>  tests/virsh-snapshot                |  2 +-
>  6 files changed, 61 insertions(+), 37 deletions(-)

ACK, although it would be great if the new function would also document
what it's doing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190708/0ccc8913/attachment-0001.sig>