[libvirt] [PATCH] util: assume modern CPU_ALLOC macros always exist

Martin Kletzander mkletzan at redhat.com
Tue Jul 9 15:10:59 UTC 2019


On Tue, Jul 09, 2019 at 12:33:54PM +0100, Daniel P. Berrangé wrote:
>Support for the modern CPU_ALLOC macros was added 10 years ago in
>
>  commit a73cd93b2428adbbc62bb919b6cf5ffd27728040
>  Author: Daniel P. Berrange <berrange at redhat.com>
>  Date:   Mon Nov 16 16:08:29 2009 +0000
>
>    Alternate CPU affinity impl to cope with NR_CPUS > 1024
>
>This is long enough that we can assume it always exists and drop the
>back compat code.
>

Yes, it was added to glibc 12 years ago, so it should be in few distros now.
I'm not sure what is the support in other libc implementations and what is our
libc support matrix, but if we either:

 a) support only glibc, or

 b) checked that other ones have that as well (ideally with a note in the commit
    message)

then I can safely say:

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190709/843a8aee/attachment-0001.sig>


More information about the libvir-list mailing list