[libvirt] [PATCH v9 07/10] backup: qemu: Implement framework for backup job APIs

Peter Krempa pkrempa at redhat.com
Tue Jul 9 15:59:35 UTC 2019


On Mon, Jul 08, 2019 at 11:55:50 -0500, Eric Blake wrote:
> Still needs to actually kick off the right QMP commands, but at
> least allows validation of backup XML, including the fact that
> a backup job can survive a libvirtd restart. Atomically creating
> a checkpoint alongside the backup still needs implementing.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/qemu/qemu_domain.h |   4 +
>  src/qemu/qemu_domain.c |  29 ++++++-
>  src/qemu/qemu_driver.c | 185 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 214 insertions(+), 4 deletions(-)

I can only re-iterate the comment of not stuffing irrelevant code into
qemuDomainObjPrivateXMLFormatBlockjobs from the last time and also point
out that the NO_METADATA flag should not be included.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190709/fa5e5171/attachment-0001.sig>


More information about the libvir-list mailing list