[libvirt] [PATCH v2 8/9] vmware: Ignore no-op flag during virDomainUndefine

Eric Blake eblake at redhat.com
Tue Jul 9 17:46:37 UTC 2019


Copy what esx does in ignoring the SNAPSHOTS_METADATA flag as a no-op,
and in line with the recent doc tweak in commit c049f022.

Signed-off-by: Eric Blake <eblake at redhat.com>
---
 src/vmware/vmware_driver.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c
index 1bc8a06c39..934378808d 100644
--- a/src/vmware/vmware_driver.c
+++ b/src/vmware/vmware_driver.c
@@ -776,7 +776,10 @@ vmwareDomainUndefineFlags(virDomainPtr dom,
     virDomainObjPtr vm;
     int ret = -1;

-    virCheckFlags(0, -1);
+    /* No managed save, so we explicitly reject
+     * VIR_DOMAIN_UNDEFINE_MANAGED_SAVE.  No snapshot metadata for
+     * vmware, so we can trivially ignore that flag.  */
+    virCheckFlags(VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA, -1);

     vmwareDriverLock(driver);
     if (!(vm = vmwareDomObjFromDomainLocked(driver, dom->uuid)))
-- 
2.20.1




More information about the libvir-list mailing list