[libvirt] [PATCH v1 14/31] virhostdevtest: Don't proceed to test cases if init failed

Michal Privoznik mprivozn at redhat.com
Thu Jul 11 15:54:01 UTC 2019


The myInit() function is called before any of the test cases
because it prepares all internal structures for individual cases.
Well, if it fails there's no point in proceeding with testing.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tests/virhostdevtest.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c
index 20eaca82e0..cf39c83c76 100644
--- a/tests/virhostdevtest.c
+++ b/tests/virhostdevtest.c
@@ -574,8 +574,11 @@ mymain(void)
             ret = -1; \
     } while (0)
 
-    if (myInit() < 0)
+    if (myInit() < 0) {
         fprintf(stderr, "Init data structures failed.");
+        virFileDeleteTree(fakerootdir);
+        return EXIT_FAILURE;
+    }
 
     DO_TEST(testVirHostdevRoundtripNoGuest);
     DO_TEST(testVirHostdevRoundtripUnmanaged);
-- 
2.21.0




More information about the libvir-list mailing list