[libvirt] [PATCH v2 16/21] utils: Extend virCommandProcessIO to including the send buffers

Stefan Berger stefanb at linux.ibm.com
Thu Jul 11 17:19:22 UTC 2019


On 7/10/19 4:05 PM, Marc-André Lureau wrote:
> On Wed, Jul 10, 2019 at 10:12 PM Stefan Berger
> <stefanb at linux.vnet.ibm.com> wrote:
>> Signed-off-by: Stefan Berger <stefanb at linux.ibm.com>
> Could you include a test?


Added in v4.


>
>> ---
>>   src/util/vircommand.c | 70 ++++++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 69 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/util/vircommand.c b/src/util/vircommand.c
>> index 0e367eeeab..357a9888a1 100644
>> --- a/src/util/vircommand.c
>> +++ b/src/util/vircommand.c
>> @@ -1803,6 +1803,69 @@ virCommandSetSendBuffer(virCommandPtr cmd,
>>   }
>>
>>
>> +static int
>> +virCommandGetNumSendBuffers(virCommandPtr cmd)
>> +{
>> +    return cmd->numSendBuffers;
>> +}
>> +
> That getter doesn't seem very useful, or at least you don't use it consistently.


Will use it consistently now.





More information about the libvir-list mailing list