[libvirt] [PATCH v4 16/23] utils: Mark inpipe as non-blocking

Stefan Berger stefanb at linux.ibm.com
Fri Jul 12 11:27:02 UTC 2019

On 7/12/19 4:24 AM, Daniel P. Berrangé wrote:
> On Thu, Jul 11, 2019 at 03:41:44PM -0400, Stefan Berger wrote:
>> Mark a virCommand's inpipe (write-end of pipe) as non-blocking so that it
>> will never block when we were to try to write too many bytes to it while
>> it doesn't have the capacity to hold them.
> So this is the right way todo it.  Why did you have the previous patch 15
> at all given you've used O_NONBLOCK here ?

I thought that with a buffer bigger than the capacity of a pipe we 
wouldn't be able to make write progress but that's not the case but it 
fills up the pipe with whatever fits. I'll drop the MIN() stuff.

More information about the libvir-list mailing list