[libvirt] [jenkins-ci PATCH] guests: Always install the freshest point release

Erik Skultety eskultet at redhat.com
Fri Jul 12 11:36:36 UTC 2019


On Wed, Jul 10, 2019 at 01:53:02PM +0200, Andrea Bolognani wrote:
> On Wed, 2019-07-10 at 09:42 +0200, Andrea Bolognani wrote:
> > On Tue, 2019-07-09 at 18:48 +0200, Erik Skultety wrote:
> > > On Tue, Jul 09, 2019 at 06:15:39PM +0200, Andrea Bolognani wrote:
> > > > diff --git a/guests/host_vars/libvirt-debian-10/install.yml b/guests/host_vars/libvirt-debian-10/install.yml
> > > > index 0a30571..d6452b6 100644
> > > > --- a/guests/host_vars/libvirt-debian-10/install.yml
> > > > +++ b/guests/host_vars/libvirt-debian-10/install.yml
> > > > @@ -1,2 +1,2 @@
> > > >  ---
> > > > -install_url: http://deb.debian.org/debian/dists/buster/main/installer-amd64/
> > > > +install_url: http://deb.debian.org/debian/dists/buster-updates/main/installer-amd64/
> > > > diff --git a/guests/host_vars/libvirt-debian-9/install.yml b/guests/host_vars/libvirt-debian-9/install.yml
> > > > index 7641753..a8c5d25 100644
> > > > --- a/guests/host_vars/libvirt-debian-9/install.yml
> > > > +++ b/guests/host_vars/libvirt-debian-9/install.yml
> > > > @@ -1,2 +1,2 @@
> > > >  ---
> > > > -install_url: http://deb.debian.org/debian/dists/stretch/main/installer-amd64/
> > > > +install_url: http://deb.debian.org/debian/dists/stretch-updates/main/installer-amd64/
> > >
> > > These 2 URLs return 404 because /installer-amd64/ directory doesn't exist.
> >
> > Good catch. Things might differ between Debian and Ubuntu on this
> > front - I'll admit I only tested Ubuntu 16.04 before sending the
> > patch. I'll look into it further and get back to you.
>
> Yeah, so it looks like Ubuntu folks create updated versions of their
> installer from time to time (each point release?), and make it
> available under ${dist}-updates, whereas Debian folks either doen't
> touch the installer after the initial release or substitute it in
> place.
>
> The takeaway is that these two hunks are incorrect, but we want the
> remaining ones. Does that sound good to you?

Yes it does.

Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list