[libvirt] [PATCH 3/4] Revert "conf: Remove volOptions for VIR_STORAGE_POOL_RBD"

Daniel P. Berrangé berrange at redhat.com
Fri Jul 12 14:42:02 UTC 2019


On Fri, Jul 12, 2019 at 04:26:07PM +0200, Ján Tomko wrote:
> This reverts commit 035db37394ad11a39d47f8bd2b6a8a2734283cbf
> 
> Even though we only allow using RBD with raw volumes,
> removing the options and the default format causes our
> parser not to fill out the volume format and the backend code
> rejects creating a non-raw volume.
> 
> Re-introduce the volume options to fix volume creation while
> erroring out on requests to use non-raw formats.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1724065
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  src/conf/storage_conf.c                           | 5 +++++
>  tests/storagepoolcapsschemadata/poolcaps-fs.xml   | 5 +++++
>  tests/storagepoolcapsschemadata/poolcaps-full.xml | 5 +++++
>  3 files changed, 15 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list