[libvirt] [libvirt-php PATCH 0/2] Add binding for virDomainInterfaceAddresses

[Michal Privoznik]

On 7/8/19 11:32 PM, Dawid Zamirski wrote:
> Hello,
> 
> The following two patches add a new bingding for virDomainInterfaceAddresses.
> While working on it I have found that the PHP7 version of the
> VIRT_ARRAY_INIT macro was causing segfaults which I have fixed in the
> first patch wheread the actual implementation of the binding is in the
> second one. Details are included in the commit messages of each patch.
> 
> Regards,
> Dawid
> 
> Dawid Zamirski (2):
>    Fix PHP7 VIRT_ARRAY_INIT macro implementation.
>    Add binding for virDomainInterfaceAddresses.
> 
>   src/libvirt-domain.c | 55 ++++++++++++++++++++++++++++++++++++++++++++
>   src/libvirt-domain.h |  2 ++
>   src/libvirt-php.c    |  9 ++++++++
>   src/util.h           |  7 +++---
>   4 files changed, 70 insertions(+), 3 deletions(-)
> 


Patches look good, but I cannot push them because they are missing your 
signoff. I can fix it, but I need your permisson to add the following at 
the end of both messages:

   Signed-off-by: Dawid Zamirski <dzamirski at datto.com>

This confirms also that you've agreed to Developer Certificate of Origin 
1.1:

   https://libvirt.org/hacking.html

Michal