[libvirt] [PATCH v1 18/31] qemu: prepare NVMe devices too

Peter Krempa pkrempa at redhat.com
Tue Jul 16 14:20:34 UTC 2019


On Thu, Jul 11, 2019 at 17:54:05 +0200, Michal Privoznik wrote:
> The qemu driver has its own wrappers around virHostdev module (so
> that some arguments are filled in automatically). Extend these to
> include NVMe devices too.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_hostdev.c | 49 ++++++++++++++++++++++++++++++++++++++---
>  src/qemu/qemu_hostdev.h | 10 +++++++++
>  2 files changed, 56 insertions(+), 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
> index 92b037e1ed..efa4d62f1f 100644
> --- a/src/qemu/qemu_hostdev.c
> +++ b/src/qemu/qemu_hostdev.c
> @@ -96,13 +96,28 @@ qemuHostdevUpdateActiveMediatedDevices(virQEMUDriverPtr driver,
>  }
>  
>  
> +int
> +qemuHostdevUpdateActiveNVMeDevices(virQEMUDriverPtr driver,

Please include "Disks" in the function name co clarify it's not a
hostdev from the domain point.

ACK to the rest

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190716/14c8fc5f/attachment-0001.sig>


More information about the libvir-list mailing list