[libvirt] [PATCH v1 22/31] qemu_domain: Separate VFIO code

Peter Krempa pkrempa at redhat.com
Tue Jul 16 14:25:35 UTC 2019


On Thu, Jul 11, 2019 at 17:54:09 +0200, Michal Privoznik wrote:
> This piece of code will be re-used later.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/conf/domain_conf.c   | 17 +++++++++++++++++
>  src/conf/domain_conf.h   |  3 +++
>  src/libvirt_private.syms |  1 +
>  src/qemu/qemu_domain.c   | 13 ++-----------
>  4 files changed, 23 insertions(+), 11 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 1b6ee3bfa6..e71e484a6f 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -31445,6 +31445,23 @@ virDomainDefHasNVMeDisk(const virDomainDef *def)
>  }
>  
>  
> +bool

If you plan to add some NVMe disk stuff to this function later please
add a comment explaining what and why is happening here.

> +virDomainDefHasVFIOHostdev(const virDomainDef *def)
> +{

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190716/c7f5dd69/attachment-0001.sig>


More information about the libvir-list mailing list