[libvirt] [PATCH 8/8] qemu: driver: Remove semi-stale comment about asynchronous job abort

Peter Krempa pkrempa at redhat.com
Thu Jul 18 16:31:43 UTC 2019


Now that we track the job separately we watch only for the abort of the
one single block job so the comment is no longer accurate. Also
describing asynchronous operation is not really necessary.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_driver.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index cd0e1d5cf8..22166c0745 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17217,12 +17217,6 @@ qemuDomainBlockJobAbort(virDomainPtr dom,

     ignore_value(virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps));

-    /*
-     * With the ABORT_ASYNC flag we don't need to do anything, the event will
-     * come from qemu and will update the XML as appropriate, but without the
-     * ABORT_ASYNC flag, we must block to guarantee synchronous operation.  We
-     * do the waiting while still holding the VM job, to prevent newly
-     * scheduled block jobs from confusing us. */
     if (!async) {
         qemuBlockJobUpdate(vm, job, QEMU_ASYNC_JOB_NONE);
         while (qemuBlockJobIsRunning(job)) {
-- 
2.21.0




More information about the libvir-list mailing list