[libvirt] [PATCH v1 1/3] virhostdev: introduce virHostdevResetAllPCIDevices
Michal Privoznik
mprivozn at redhat.com
Fri Jul 19 11:52:50 UTC 2019
On 7/18/19 10:10 PM, Daniel Henrique Barboza wrote:
> This code that executes virPCIDeviceReset in all virPCIDevicePtr
> objects of a given virPCIDeviceListPtr list is replicated twice
> in the code. Putting it in a helper function helps with
> readability.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> ---
> src/util/virhostdev.c | 54 +++++++++++++++++++++++--------------------
> 1 file changed, 29 insertions(+), 25 deletions(-)
>
> diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
> index a3647a6cf4..7cb0beb545 100644
> --- a/src/util/virhostdev.c
> +++ b/src/util/virhostdev.c
> @@ -613,6 +613,32 @@ virHostdevRestoreNetConfig(virDomainHostdevDefPtr hostdev,
> }
> }
>
> +static int
> +virHostdevResetAllPCIDevices(virPCIDeviceListPtr pcidevs,
> + virHostdevManagerPtr mgr)
Small nit pick here, I prefer arguments appearing in their order of
importance. That means, virHostdevManager is more important than the
virPCIDeviceList, because the manager is built on the top of virpci module.
> +{
> + int ret = 0;
> + size_t i;
> +
> + for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
> + virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
> +
> + /* We can avoid looking up the actual device here, because performing
> + * a PCI reset on a device doesn't require any information other than
> + * the address, which 'pci' already contains */
> + VIR_DEBUG("Resetting PCI device %s", virPCIDeviceGetName(pci));
> + if (virPCIDeviceReset(pci, mgr->activePCIHostdevs,
> + mgr->inactivePCIHostdevs) < 0) {
> + VIR_ERROR(_("Failed to reset PCI device: %s"),
> + virGetLastErrorMessage());
> + virResetLastError();
> + ret = -1;
> + }
> + }
> +
> + return ret;
> +}
> +
Michal
More information about the libvir-list
mailing list