[libvirt] [PATCH] virsh migrate: Properly check for --parallel-connections

[Michal Privoznik]

On 7/19/19 4:05 PM, Jiri Denemark wrote:
> Ever since --parallel-connections option for virsh migrate was
> introduced we did not properly check the return value of
> vshCommandOptInt. We would set VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS
> parameter even if vshCommandOptInt returned 0 (which means
> --parallel-connections was not specified) when another int option which
> was checked earlier was specified with a nonzero value.
> 
> Specifically, running virsh migrate with either
> --auto-converge-increment, --auto-converge-initial, --comp-mt-dthreads,
> --comp-mt-threads, or --comp-mt-level would set
> VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS parameter and if --parallel
> option was not used, libvirt would complain
> 
>      error: invalid argument: Turn parallel migration on to tune it
> 
> even though --parallel-connections option was not used at all.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1726643
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>   tools/virsh-domain.c | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal