[libvirt] [PATCH 1/4] qemu: Remove unnecessary check in qemuMonitorJSONGetJobInfoOne

John Ferlan jferlan at redhat.com
Tue Jul 23 13:58:08 UTC 2019


It's already dereffed in the initialization and shouldn't be NULL
unless virJSONValueArraySize after a virJSONValueObjectGetArray
could return a NULL data entry.

Found by Coverity

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/qemu/qemu_monitor_json.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index f19dced014..d38b2f2cbe 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -9133,9 +9133,6 @@ qemuMonitorJSONGetJobInfoOne(virJSONValuePtr data)
     VIR_AUTOPTR(qemuMonitorJobInfo) job = NULL;
     qemuMonitorJobInfoPtr ret = NULL;
 
-    if (!data)
-        return NULL;
-
     if (VIR_ALLOC(job) < 0)
         return NULL;
 
-- 
2.20.1




More information about the libvir-list mailing list