[libvirt] [PATCH 2/4] test: Return early in testQueryJobs

John Ferlan jferlan at redhat.com
Tue Jul 23 13:58:09 UTC 2019


Avoid the chance that qemuMonitorTestNewSimple could return NULL

Found by Coverity

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 tests/qemumonitorjsontest.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index 8eb9d2e01b..bf89f49aca 100644
--- a/tests/qemumonitorjsontest.c
+++ b/tests/qemumonitorjsontest.c
@@ -2959,6 +2959,9 @@ testQueryJobs(const void *opaque)
     size_t i;
     int ret = -1;
 
+    if (!test)
+        return -1;
+
     if (virAsprintf(&filenameJSON,
                     abs_srcdir "/qemumonitorjsondata/query-jobs-%s.json",
                     data->name) < 0 ||
-- 
2.20.1




More information about the libvir-list mailing list