[libvirt] [PATCH 2/4] tests: Call virCommandFree() in cleanup section
Stefan Berger
stefanb at linux.vnet.ibm.com
Fri Jul 26 13:42:44 UTC 2019
Fix a potential memory leak by calling virCommandFree() in the cleanup
section.
Signed-off-by: Stefan Berger <stefanb at linux.ibm.com>
---
tests/commandtest.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/commandtest.c b/tests/commandtest.c
index 991c0572b0..dfd15a2079 100644
--- a/tests/commandtest.c
+++ b/tests/commandtest.c
@@ -1219,8 +1219,6 @@ static int test27(const void *unused ATTRIBUTE_UNUSED)
goto cleanup;
}
- virCommandFree(cmd);
-
if (!outactual || !erractual)
goto cleanup;
@@ -1236,6 +1234,7 @@ static int test27(const void *unused ATTRIBUTE_UNUSED)
ret = 0;
cleanup:
+ virCommandFree(cmd);
VIR_FORCE_CLOSE(pipe1[0]);
VIR_FORCE_CLOSE(pipe2[0]);
VIR_FORCE_CLOSE(pipe1[1]);
--
2.20.1
More information about the libvir-list
mailing list