[libvirt] [PATCH 08/41] remote: conditionalize daemon name in libvirtd daemon

Andrea Bolognani abologna at redhat.com
Fri Jul 26 15:39:01 UTC 2019


On Fri, 2019-07-26 at 16:24 +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 26, 2019 at 02:39:51PM +0200, Andrea Bolognani wrote:
> > On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote:
> > [...]
> > > +++ b/src/remote/remote_driver.h
> > > @@ -34,7 +34,6 @@ unsigned long remoteVersion(void);
> > >  #define LIBVIRTD_PRIV_UNIX_SOCKET LOCALSTATEDIR "/run/libvirt/libvirt-sock"
> > >  #define LIBVIRTD_PRIV_UNIX_SOCKET_RO LOCALSTATEDIR "/run/libvirt/libvirt-sock-ro"
> > >  #define LIBVIRTD_USER_UNIX_SOCKET "libvirt-sock"
> > > -#define LIBVIRTD_CONFIGURATION_FILE SYSCONFDIR "/libvirt/libvirtd.conf"
> > 
> > Oh, this was unused even before your changes, wasn't it? You should
> > drop it in a separate, trivial patch.
> 
> No it was used, but this should have been done in patch 6 instead.

Right you are! I just checked @^ instead of master... The hunk should
be squashed into patch 6 then.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list